fix(policy-kit): increase timeout for generator tests that spawn child processes#700
Merged
Merged
Conversation
jithinraj
added a commit
that referenced
this pull request
May 6, 2026
The "1,000 issuances produce 1,000 unique jti values" property test in packages/protocol/__tests__/jti-collision.property.test.ts performs 1,000 sequential issueWire02 + verifyLocal round-trips. Local runs complete in ~3s on a warm cache, but the rollback-path matrix CI lane (Node 24, flag 0) hit the Vitest 5s default and timed out on a cold runner. Raise the per-test timeout to 30,000ms via the third argument to it(). This mirrors the v0.12.14 #700 cold-CI timeout raise pattern for the policy-kit generator tests. Test logic, assertions, and behavior are unchanged; only the wall-clock budget is increased to absorb cold-cache variance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
generator.test.tstests that callexecSync('pnpm generate:profiles:check')andexecSync('pnpm generate:profiles')were hitting the default 5000ms Vitest timeout on CI runners. Locally they complete in ~2.5s but cold CI runners with pnpm startup overhead exceed 5s.Scope
{ timeout: 30000 }to the twoitblocks that spawn child processes inpackages/policy-kit/tests/generator.test.ts.Validation
Tests pass locally. 30s timeout is well above the worst-case CI runner cold-start time.